Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the type of type_uid from integer to long. #928

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

pagbabian-splunk
Copy link
Contributor

Related Issue: 812

Description of changes: Changed the data type of type_uid from integer_t to long_t.

The value can overflow when extensions are in play.

@pagbabian-splunk pagbabian-splunk added bug Something isn't working framework Structures, conventions, requirements, data types, etc. v1.1.0 Changes marked for v1.1.0 of OCSF labels Jan 9, 2024
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@floydtree floydtree merged commit 2a82437 into main Jan 9, 2024
2 checks passed
@floydtree floydtree deleted the fix_data_type branch January 9, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework Structures, conventions, requirements, data types, etc. v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants