Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Create, Delete activity ids to 3006 event class #929

Merged
merged 9 commits into from
Jan 10, 2024

Conversation

zschmerber
Copy link
Contributor

Related Issue:

#919

Description of changes:

This PR is to add some Missing CRUD values to the 3006 class.

@zschmerber zschmerber added enhancement New feature or request iam Issues related to Identity & Access Management Category non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF labels Jan 10, 2024
@zschmerber zschmerber self-assigned this Jan 10, 2024
@zschmerber zschmerber marked this pull request as ready for review January 10, 2024 01:46
Aniak5
Aniak5 previously approved these changes Jan 10, 2024
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

events/iam/group_management.json Outdated Show resolved Hide resolved
Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zschmerber zschmerber merged commit 5190d85 into ocsf:main Jan 10, 2024
2 checks passed
@floydtree floydtree changed the title CRUD values to the 3006 class Adding Create, Delete activity ids to 3006 event class Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iam Issues related to Identity & Access Management Category non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants