Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Sedara schema extension #951

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

cabrel
Copy link
Contributor

@cabrel cabrel commented Feb 1, 2024

Related Issue:

Description of changes:

Registering a schema extension id for Sedara.

@cabrel cabrel marked this pull request as ready for review February 1, 2024 19:55
@floydtree
Copy link
Contributor

@cabrel One quick note, can you add an entry in the unreleased section in CHANGELOG.md file? You can refer to the previous entries for reference.

@floydtree floydtree added documentation Improvements or additions to documentation v1.2.0 Changes marked for version v1.2.0 of OCSF labels Feb 6, 2024
@mikeradka
Copy link
Contributor

LGTM once the CHANGELOG is updated

@pagbabian-splunk
Copy link
Contributor

Same: LGTM but needs CHANGELOG

Add entry under Misc regarding extension registration

Signed-off-by: Robin Harper <[email protected]>
CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aniak5 Aniak5 merged commit cf7af89 into ocsf:main Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation v1.2.0 Changes marked for version v1.2.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants