Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Client Application attributes to the Actor object #979

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

pagbabian-splunk
Copy link
Contributor

@pagbabian-splunk pagbabian-splunk commented Mar 7, 2024

Related Issue: #966

Description of changes:

Created the app_uid attribute to the dictionary.
Added app_name and app_uid to the Actor object as client app attributes. Updated the descriptions and constraints.
Deprecated invoked_by for the object only.
Updated the CHANGELOG.

@pagbabian-splunk pagbabian-splunk added enhancement New feature or request non_breaking Non Breaking, backwards compatible changes description_updates Issues related to missing/incorrect/lacking descriptions of attributes v1.2.0 Changes marked for version v1.2.0 of OCSF labels Mar 7, 2024
@pagbabian-splunk pagbabian-splunk requested review from floydtree and removed request for floydtree March 7, 2024 16:47
objects/actor.json Outdated Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pagbabian-splunk pagbabian-splunk merged commit 0347555 into main Mar 13, 2024
2 checks passed
@floydtree floydtree deleted the client_app2 branch March 13, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
description_updates Issues related to missing/incorrect/lacking descriptions of attributes enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.2.0 Changes marked for version v1.2.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants