-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Client Application attributes to the Actor object #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Agbabian <[email protected]>
…GELOG. Signed-off-by: Paul Agbabian <[email protected]>
Signed-off-by: Paul Agbabian <[email protected]>
pagbabian-splunk
added
enhancement
New feature or request
non_breaking
Non Breaking, backwards compatible changes
description_updates
Issues related to missing/incorrect/lacking descriptions of attributes
v1.2.0
Changes marked for version v1.2.0 of OCSF
labels
Mar 7, 2024
pagbabian-splunk
requested review from
floydtree,
Aniak5,
mikeradka and
zschmerber
as code owners
March 7, 2024 16:47
pagbabian-splunk
requested review from
floydtree
and removed request for
floydtree
March 7, 2024 16:47
alanisaac
reviewed
Mar 7, 2024
Aniak5
reviewed
Mar 12, 2024
…uid. Signed-off-by: Paul Agbabian <[email protected]>
Signed-off-by: Paul Agbabian <[email protected]>
Signed-off-by: Paul Agbabian <[email protected]>
Aniak5
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
floydtree
approved these changes
Mar 13, 2024
zschmerber
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
description_updates
Issues related to missing/incorrect/lacking descriptions of attributes
enhancement
New feature or request
non_breaking
Non Breaking, backwards compatible changes
v1.2.0
Changes marked for version v1.2.0 of OCSF
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #966
Description of changes:
Created the
app_uid
attribute to the dictionary.Added
app_name
andapp_uid
to theActor
object as client app attributes. Updated the descriptions and constraints.Deprecated
invoked_by
for the object only.Updated the CHANGELOG.