Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ways to define observables to metaschema #982

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

rmouritzen-splunk
Copy link
Contributor

@rmouritzen-splunk rmouritzen-splunk commented Mar 11, 2024

Related Issues:

Related PRs:

Description of changes:

This change adds the ability to define observables in dictionary attributes and in classes as class-specific observables by attribute path.

This change also validates all observable type_id definitions. This is enabled by an update to the ocsf-validator tool.

@rmouritzen-splunk rmouritzen-splunk added enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.2.0 Changes marked for version v1.2.0 of OCSF labels Mar 11, 2024
@rmouritzen-splunk rmouritzen-splunk marked this pull request as draft March 11, 2024 06:44
@rmouritzen-splunk rmouritzen-splunk changed the title Add new ways to define observables to metaschema DRAFT: Add new ways to define observables to metaschema Mar 11, 2024
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmouritzen-splunk rmouritzen-splunk changed the title DRAFT: Add new ways to define observables to metaschema Add new ways to define observables to metaschema Mar 12, 2024
@rmouritzen-splunk rmouritzen-splunk marked this pull request as ready for review March 12, 2024 19:56
@rmouritzen-splunk rmouritzen-splunk merged commit ba1cb34 into ocsf:main Mar 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.2.0 Changes marked for version v1.2.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants