Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 985: Added file attribute to http, rdp, ssh, and ftp event classes #990

Merged
merged 11 commits into from
Apr 3, 2024

Conversation

Aniak5
Copy link
Contributor

@Aniak5 Aniak5 commented Mar 19, 2024

Related Issue:

#985

Description of changes:

  • Added optional file attribute to http, rdp, smb, ssh, and ftp network event classes
image image

@Aniak5 Aniak5 added network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes application_activity Issues related to Application Activity Category labels Mar 19, 2024
@Aniak5 Aniak5 self-assigned this Mar 19, 2024
@floydtree floydtree changed the title Issue 985 Issue 985: Adding file profile to api activity, web_resources_activity and all network event classes Mar 19, 2024
@Aniak5 Aniak5 changed the title Issue 985: Adding file profile to api activity, web_resources_activity and all network event classes Issue 985: Adding file attribute to HTTP/RDP/SMB/FTP/SSH network classes Mar 27, 2024
@Aniak5 Aniak5 changed the title Issue 985: Adding file attribute to HTTP/RDP/SMB/FTP/SSH network classes Issue 985: Added file object to http, rdp, smb, ssh, and ftp event classes Mar 27, 2024
@Aniak5 Aniak5 changed the title Issue 985: Added file object to http, rdp, smb, ssh, and ftp event classes Issue 985: Added file attribute to http, rdp, smb, ssh, and ftp event classes Mar 27, 2024
@Aniak5 Aniak5 changed the title Issue 985: Added file attribute to http, rdp, smb, ssh, and ftp event classes Issue 985: Added file attribute to http, rdp, ssh, and ftp event classes Mar 27, 2024
Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@floydtree floydtree merged commit 0ae6d4a into ocsf:main Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application_activity Issues related to Application Activity Category network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants