-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 985: Added file
attribute to http
, rdp
, ssh
, and ftp
event classes
#990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aniak5
added
network_activity
Issues related to Network Activity Category
non_breaking
Non Breaking, backwards compatible changes
application_activity
Issues related to Application Activity Category
labels
Mar 19, 2024
Aniak5
requested review from
floydtree,
pagbabian-splunk,
mikeradka and
zschmerber
as code owners
March 19, 2024 15:05
floydtree
changed the title
Issue 985
Issue 985: Adding file profile to api activity, web_resources_activity and all network event classes
Mar 19, 2024
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
…network classes Signed-off-by: Ania Kacewicz <[email protected]>
Aniak5
changed the title
Issue 985: Adding file profile to api activity, web_resources_activity and all network event classes
Issue 985: Adding file attribute to HTTP/RDP/SMB/FTP/SSH network classes
Mar 27, 2024
Aniak5
changed the title
Issue 985: Adding file attribute to HTTP/RDP/SMB/FTP/SSH network classes
Issue 985: Added Mar 27, 2024
file
object to http
, rdp
, smb
, ssh
, and ftp
event classes
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Aniak5
changed the title
Issue 985: Added
Issue 985: Added Mar 27, 2024
file
object to http
, rdp
, smb
, ssh
, and ftp
event classesfile
attribute to http
, rdp
, smb
, ssh
, and ftp
event classes
Aniak5
changed the title
Issue 985: Added
Issue 985: Added Mar 27, 2024
file
attribute to http
, rdp
, smb
, ssh
, and ftp
event classesfile
attribute to http
, rdp
, ssh
, and ftp
event classes
Signed-off-by: Ania Kacewicz <[email protected]>
floydtree
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
mikeradka
approved these changes
Mar 28, 2024
zschmerber
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
application_activity
Issues related to Application Activity Category
network_activity
Issues related to Network Activity Category
non_breaking
Non Breaking, backwards compatible changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
#985
Description of changes:
file
attribute tohttp
,rdp
,smb
,ssh
, andftp
network event classes