-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metaschema: support event class and object attribute observables #993
Conversation
f8b49c6
to
db444ca
Compare
…e hard-coded list of categories from metadata/categories.schema.json, leaving this to the ocsf-validator. This change makes testing with alternate schemas that may add extra categories easier. It also makes it possible to validate private extensions that contain new categories.
…lasses, and detect invalid "observables" property in objects. Update CHANGELOG.md with metaschema changes and improvements
cdfb10a
to
3492a14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I like how you've refactored common properties to common-event-object.schema.json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related Issue:
observables
data types, add Name & ID pairs #960Description of changes:
Metaschema changes.
metaschema/categories.schema.json
, leaving this to theocsf-validator
. This change makes testing with alternate schemas that may add extra categories easier, as well as making it possible to validate private extensions that contain new categories.observable
property in event classes, and invalid top-levelobservables
property in objects.