Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply conditions/scopes to related model query #536

Merged
merged 26 commits into from
Nov 20, 2020
Merged

Apply conditions/scopes to related model query #536

merged 26 commits into from
Nov 20, 2020

Commits on Oct 26, 2020

  1. override Laravel Relation sync() method

    @mjauvin
    mjauvin committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    4b23c80 View commit details
    Browse the repository at this point in the history

  2. fix code quality

    @mjauvin
    mjauvin committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    9e19b66 View commit details
    Browse the repository at this point in the history

  3. fix comment

    @mjauvin
    mjauvin committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    624461a View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. fix detach method to only detach related ids, honoring the conditions… 

    … & scopes
    @mjauvin
    mjauvin committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    9775ab5 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. Update src/Database/Relations/BelongsToMany.php

    Luke Towers authored Oct 29, 2020
    Configuration menu
    Copy the full SHA
    7fee28b View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2020

  1. rewrite getCurrentlyAttachedPivots() to take conditions and scopes in… 

    …to account
    @mjauvin
    mjauvin committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    8db8f62 View commit details
    Browse the repository at this point in the history

  2. simplify code a bit

    @mjauvin
    mjauvin committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    4943e24 View commit details
    Browse the repository at this point in the history

  3. remove unused Pivot class

    @mjauvin
    mjauvin committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    e561aa9 View commit details
    Browse the repository at this point in the history

  4. no need to complicate things here...

    @mjauvin
    mjauvin committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    c613535 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. add initial relations tests

    @mjauvin
    mjauvin committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    560bc08 View commit details
    Browse the repository at this point in the history

  2. remove empty line before closing brace

    @mjauvin
    mjauvin committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    cef177d View commit details
    Browse the repository at this point in the history

  3. add DbTestCase and use it for tests needing database

    @mjauvin
    mjauvin committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    246337d View commit details
    Browse the repository at this point in the history

  4. add actual tests that prove this PR resolves the issue

    @mjauvin
    mjauvin committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    1965c62 View commit details
    Browse the repository at this point in the history

  5. complet tests

    @mjauvin
    mjauvin committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    22ccd13 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2020

  1. flush event listeners on models after each test

    @mjauvin
    mjauvin committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    4d1887d View commit details
    Browse the repository at this point in the history

  2. add tearDown method to DbTestCase to flush event listeners on instanc… 

    …iated models
    @mjauvin
    mjauvin committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    b57d1b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. fix method names

    @mjauvin
    mjauvin committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    2b8c815 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2020

  1. rework DbTestCase class handling

    @mjauvin
    mjauvin committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    957cda2 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2020

  1. call parent::attach() instead of duplicating code here

    @mjauvin
    mjauvin committed Nov 8, 2020
    Configuration menu
    Copy the full SHA
    9187bf4 View commit details
    Browse the repository at this point in the history

  2. Revert "call parent::attach() instead of duplicating code here" 

    This reverts commit 9187bf4.
    @mjauvin
    mjauvin committed Nov 8, 2020
    Configuration menu
    Copy the full SHA
    8a205f8 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. add spaces around => operator 

    Co-authored-by: Ben Thomson <[email protected]>
    @mjauvin
    mjauvin and Ben Thomson authored Nov 10, 2020
    Configuration menu
    Copy the full SHA
    83fa7db View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix-sync-relations

    @mjauvin
    mjauvin committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    c86f3e4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix-sync-relations' of github.com:mjauvin/library into … 

    …fix-sync-relations
    @mjauvin
    mjauvin committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    4ba0258 View commit details
    Browse the repository at this point in the history

  4. add multiple records sync and single record detach

    @mjauvin
    mjauvin committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    4e0f857 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. find the last category type term and detach it

    @mjauvin
    mjauvin committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    1c17771 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. flush cache after query if needed

    @mjauvin
    mjauvin committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    e213586 View commit details
    Browse the repository at this point in the history