-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more relation events #537
Conversation
One thing to attach/detach event. I thought that it was written previously like you can halt whole procedure through false value returned on before*** event. It's not possible now? And do you plan to implement HasOneOrMany, AttachOneOrMany, MorphOneOrMany? |
@LukeTowers requested this to be changed. The way to halt these is to throw an exception now.
For which events? I thought you said you were now thinking this was not required, did I read that wrong? ref.
|
@mjauvin I was thinking, but last word has @LukeTowers. Can you tell us, what do you think about HasOneOrMany, AttachOneOrMany, MorphOneOrMany events, @LukeTowers? Useless? Edit: I thought about two approaches to HasOneOrMany etc. and definitelly yes, add/remove-events is good and more clean idea. |
This is ready guys. |
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
Can this be added to Milestone 1.1.2? |
Will add it to 1.1.3 instead |
Co-authored-by: Ben Thomson <[email protected]>
Still some work needed on this, in particular, adherence to the developer guide and before events should halt to meet continuity with the rest of the platform Overall looks good though, will be available in next release. Thanks @mjauvin 🙏 |
Fixes: octobercms/october#4561