Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): export minimal types required for the App class #536

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix(types): export minimal types required for the App class #536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@ import type {
EachRepositoryInterface,
GetInstallationOctokitInterface,
} from "./types.js";

// Export types required for the App class
// This is in order to fix a TypeScript error in downstream projects:
// The inferred type of 'App' cannot be named without a reference to '../node_modules/@octokit/app/dist-types/types.js'. This is likely not portable. A type annotation is necessary.
export type {
EachInstallationInterface,
EachRepositoryInterface,
GetInstallationOctokitInterface,
} from "./types.js";

import { VERSION } from "./version.js";
import { webhooks } from "./webhooks.js";
import { eachInstallationFactory } from "./each-installation.js";
Expand Down