Implement Deployment Statuses Preview #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Cyberboss sorry I haven't reviewed yet, I'll take a look this week 👍 |
ryangribble
suggested changes
Nov 7, 2018
There was a problem hiding this comment.
This looks great @Cyberboss
Just one minor request around the unit tests, to fix up the previous usage of the AcceptHeader const/variable, in favour of hardcoding the expected header string like the other tests already do 👍
Have you run any integration tests or confirmed that these changes do actually work?
Codecov Report
@@ Coverage Diff @@
## master #1895 +/- ##
==========================================
+ Coverage 66.94% 66.95% +<.01%
==========================================
Files 542 542
Lines 14223 14228 +5
==========================================
+ Hits 9522 9526 +4
- Misses 4701 4702 +1
|
Also fix the lack of preview headers in the repositoryId version
shiftkey
force-pushed
the
ImplementDeploymentEnums
branch
from
c37e530
to
b6ad71e
Compare
|
@ryangribble I added a new test to leverage the new properties, integration tests are passing locally |
|
release_notes: Added support for Deployment Status API improvements |
|
Thanks for finishing this ancient thing off guys! |
nickfloyd
added
Type: Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.github.com/changes/2018-10-16-deployments-environments-states-and-auto-inactive-updates/
https://developer.github.com/v3/previews/#deployment-statuses