Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): switch to esbuild from pika #571

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Conversation

kfcampbell
Copy link
Member

Replicating octokit/request.js#584 to another repo.


Pika has been deprecated for a while now, and the project has now been archived, and because of that the released npm package is missing most of the files generated by the build step.

Uses esbuild to transpile the TS source code into an ESM source, NodeJs bundle, and a browser bundle

Uses the TypeScript compiler to generate the types.

Behavior

Before the change?

  • Uses pika for the build system
  • The released npm package is missing most of the files generated by the build step. dist-node, dist-types, dist-web... even though they are generated correctly.

After the change?

  • Uses esbuild to generate the JS bundles
  • Uses the TypeScript compiler to generate the type definitions
  • The correct file matching patterns are used so we publish all the necessary files again.

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Dependencies/code cleanup: Type: Maintenance

@kfcampbell kfcampbell added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 7, 2023
@kfcampbell
Copy link
Member Author

#572 and a subsequent generation update are required to turn on verbatimModuleSyntax.

@wolfy1339
Copy link
Member

Should've regenerated the types in #572 with the template change 🤦

Oh well. It can be done here. In fact, #572 could have been in this PR since it's all related

@kfcampbell
Copy link
Member Author

You're right; that would've been smart. I've kicked off this Actions run which will hopefully give us an update PR shortly.

@kfcampbell
Copy link
Member Author

#573 is that update PR!

@kfcampbell kfcampbell merged commit 0374dea into main Jun 8, 2023
@kfcampbell kfcampbell deleted the switch-to-esbuild branch June 8, 2023 22:50
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

🎉 This PR is included in version 12.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants