-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pkg): add default fallback and types export #612
Conversation
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
man I really hoped that with the ESM standard we would put all this nonsense behind us 😭 thank you for seeing the transition through and addressing the follow ups ❤️
It seems nobody has the same idea of how to interpret the standard |
🎉 This PR is included in version 11.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves octokit/core.js#667
Resolves octokit/core.js#665
Before the change?
jest
,ts-node
,tsx
)After the change?
dist-types/types.d.ts
file in the packagePull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!