Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Undici network errors still not surfaced properly #644

Closed
1 task done
nikhilgupta345 opened this issue Oct 9, 2023 · 2 comments · Fixed by #643
Closed
1 task done

[BUG]: Undici network errors still not surfaced properly #644

nikhilgupta345 opened this issue Oct 9, 2023 · 2 comments · Fixed by #643
Labels
released Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@nikhilgupta345
Copy link
Contributor

What happened?

Undici surfaces network errors as type errors with the actual error under cause. A previous attempt to fix this assumed that cause was a string. After testing further, cause can be an Error as well. We do not handle this case and so Errors do not get surfaced appropriately.

This presents all network errors as "fetch failed" rather than showing the actual error.

Versions

All versions of Octokit

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nikhilgupta345 nikhilgupta345 added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@nikhilgupta345 nikhilgupta345 mentioned this issue Oct 9, 2023
Merged
4 tasks
@nikhilgupta345 nikhilgupta345 changed the title [BUG]: [BUG]: Undici network errors still not surfaced properly Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

🎉 This issue has been resolved in version 8.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: error.cause from undici may be instance of Error nikhilgupta345/request.js
1 participant
@nikhilgupta345