fix: error.cause from undici may be instance of Error
#643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilgupta345
changed the title
wolfy1339
approved these changes
Oct 9, 2023
wolfy1339
changed the title
error.cause from undici may be instance of Error
|
🎉 This PR is included in version 8.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #644
Before the change?
I found in my testing that undici may surface the
causeproperty as an Error rather than as a plain string. This meant this if block never got executed and we never bubbled up the actual cause.After the change?
Correctly handle
causeas an Error or as a string, and bubble up the message from the Error, if present.Pull request checklist
Does this introduce a breaking change?