Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions #669

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Add permissions #669

merged 2 commits into from
Feb 9, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 9, 2024

Resolves #668


Before the change?

  • Error: Input required and not supplied: github-token
  • Error: Resource not accessible by integration

After the change?

  • stale-bot will be annoying in forks
  • codeql will work in paranoid forks

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

github-actions bot commented Feb 9, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

Can you make the changes to the add to octokit project workflow in https://github.com/octokit/.github/blob/main/.github/templates/add_to_octokit_project.yml instead

@jsoref
Copy link
Contributor Author

jsoref commented Feb 9, 2024

@wolfy1339: done

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Feb 9, 2024
@wolfy1339
Copy link
Member

It would probably be nice to go across the Octokit repos and do the same changes

@wolfy1339 wolfy1339 merged commit 8a58080 into octokit:main Feb 9, 2024
6 checks passed
@wolfy1339
Copy link
Member

It seems this has introduced unintended issues. The release workflow is failing with the same error that you got that led to this PR

@jsoref
Copy link
Contributor Author

jsoref commented Feb 9, 2024

Oh, that one probably needs contents: write -- I misguessed how the workflow worked.

@jsoref jsoref deleted the add-permissions branch February 9, 2024 12:43
@jsoref
Copy link
Contributor Author

jsoref commented Feb 11, 2024

It would probably be nice to go across the Octokit repos and do the same changes

I'd probably eventually do this as I run into a need to contribute to them. Or I might do it as a batch. Given how quickly you responded to this series, I'm more inclined to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Workflows fail on forks
2 participants