Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spelling #671

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix Spelling #671

merged 2 commits into from
Feb 9, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 9, 2024

Resolves #670


Before the change?

  • typos (conjuction, case insensitive)

After the change?

  • accepted spellings (conjunction, case-insensitive)

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

github-actions bot commented Feb 9, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

These changes look good.

Unfortunately I can't accept changes to the immediate response workflow, as it is updated from a template in a central repository and would be overwritten by future updates.

Can you resubmit that change here: https://github.com/octokit/.github/blob/main/.github/templates/immediate-response.yml

That way it will be updated across all the other Octokit repos

@jsoref
Copy link
Contributor Author

jsoref commented Feb 9, 2024

@wolfy1339: done

@wolfy1339 wolfy1339 merged commit c013de4 into octokit:main Feb 9, 2024
6 checks passed
@jsoref jsoref deleted the spelling branch February 9, 2024 07:49
Copy link

github-actions bot commented Feb 9, 2024

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Apr 5, 2024

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Typos in repository
2 participants