remove glob dependency #701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
wolfy1339
added
the
Type: Maintenance
gr2m
reviewed
Jun 29, 2024
wolfy1339
reviewed
Jul 2, 2024
Comment on lines
-27
to
-35
| // Remove the types file from the dist-src folder | ||
| const typeFiles = await glob([ | ||
| "./pkg/dist-src/**/types.js.map", | ||
| "./pkg/dist-src/**/types.js", | ||
| ]); | ||
| for (const typeFile of typeFiles) { | ||
| await rm(typeFile); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why was this removed? Whenever we have a types.ts file it would create an empty types.js file which is useless
|
There is no types.ts file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we dont need glob ;)