Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace toStrictEqual with JSON.stringify Response assertions with toEqual in rest.js #328

Closed
Tracked by #588
oscard0m opened this issue Jul 19, 2023 · 1 comment · Fixed by #329
Closed
Tracked by #588

Replace toStrictEqual with JSON.stringify Response assertions with toEqual in rest.js #328

oscard0m opened this issue Jul 19, 2023 · 1 comment · Fixed by #329
Assignees
@oscard0m
Labels
released

Comments

@oscard0m
Copy link
Member

oscard0m commented Jul 19, 2023 •
edited
Loading

Subtask of octokit/core.js#588
@oscard0m oscard0m mentioned this issue Jul 19, 2023
Closed
5 tasks
@oscard0m oscard0m transferred this issue from octokit/core.js Jul 19, 2023
@oscard0m oscard0m self-assigned this Jul 19, 2023
@oscard0m oscard0m mentioned this issue Jul 19, 2023
Merged
5 tasks
@oscard0m oscard0m moved this from 🆕 Triage to 👀 In review in 🧰 Octokit Active Jul 19, 2023
oscard0m added a commit that referenced this issue Jul 19, 2023
@oscard0m
test(refactor): use 'toEqual' instead of 'toStrictEqual' for Responses (
0303720 
#329)

<!-- Issues are required for both bug fixes and features. -->
Resolves #328

----

## Behavior

### Before the change?
<!-- Please describe the current behavior that you are modifying. -->
Test assertions of Responses from `fetch-mock` are done with
`jest.toStrictEqual` with `JSON.stringify`

### After the change?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
Test assertions of Responses from `fetch-mock` are done with
`jest.toEqual`


### Other information
<!-- Any other information that is important to this PR  -->
More context in octokit/core.js#588

----

## Additional info

### Pull request checklist
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been reviewed and added / updated if needed (for bug
fixes / features)
- [ ] Added the appropriate label for the given change

### Does this introduce a breaking change?
<!-- If this introduces a breaking change make sure to note it here any
what the impact might be -->

Please see our docs on [breaking
changes](https://github.com/octokit/.github/blob/main/community/breaking_changes.md)
to help!

- [ ] Yes (Please add the `Type: Breaking change` label)
- [x] No

If `Yes`, what's the impact:

* N/A


### Pull request type
`Type: Maintenance`

----
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in 🧰 Octokit Active Jul 19, 2023
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 20.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscard0m oscard0m

Labels
released
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(refactor): use 'toEqual' instead of 'toStrictEqual' for Responses octokit/rest.js
1 participant
@oscard0m