Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: activate more tests, update @octokit/plugin-request-log dep #451

Closed
wants to merge 1 commit into from
Closed

fix: activate more tests, update @octokit/plugin-request-log dep #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 108 additions & 42 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,21 +36,21 @@
"dependencies": {
"@octokit/core": "^6.1.2",
"@octokit/plugin-paginate-rest": "^11.0.0",
"@octokit/plugin-request-log": "^5.1.0",
"@octokit/plugin-request-log": "^5.3.1",
"@octokit/plugin-rest-endpoint-methods": "^13.0.0"
},
"devDependencies": {
"@octokit/auth-action": "^5.1.0",
"@octokit/auth-app": "^7.0.0",
"@octokit/fixtures-server": "^8.1.0",
"@octokit/request": "^9.1.1",
"@octokit/request": "^9.1.3",
"@octokit/tsconfig": "^3.0.0",
"@types/node": "^20.11.5",
"@vitest/coverage-v8": "^2.0.3",
"esbuild": "^0.23.0",
"fetch-mock": "^10.0.0",
"glob": "^11.0.0",
"nock": "^13.5.0",
"nock": "14.0.0-beta.8",
"prettier": "^3.2.4",
"semantic-release-plugin-update-version-in-files": "^1.1.0",
"typescript": "^5.3.3",
Expand Down
12 changes: 6 additions & 6 deletions test/integration/conditional-request-test.js → test/integration/conditional-request.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
const nock = require("nock");

const { Octokit } = require("../../");
import { describe, beforeEach, it, expect } from "vitest";
import nock from "nock";
import { Octokit } from "../../src/index.ts";

describe("request 304s", () => {
let octokit;
let octokit: Octokit;

beforeEach(() => {
octokit = new Octokit({
Expand All @@ -16,7 +16,7 @@ describe("request 304s", () => {

return octokit.rest.orgs
.get({ org: "myorg", headers: { "If-None-Match": "etag" } })
.then((response) => {
.then(() => {
expect.fail("should throw error");
})
.catch((error) => {
Expand All @@ -34,7 +34,7 @@ describe("request 304s", () => {
"If-Modified-Since": "Sun Dec 24 2017 22:00:00 GMT-0600 (CST)",
},
})
.then((response) => {
.then(() => {
expect.fail("should throw error");
})
.catch((error) => {
Expand Down
12 changes: 6 additions & 6 deletions test/integration/pagination-test.js → test/integration/pagination.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const nock = require("nock");

const { Octokit } = require("../../");
import { describe, it, expect } from "vitest";
import nock from "nock";
import { Octokit } from "../../src/index.ts";

describe("pagination", () => {
it(".paginate()", () => {
Expand Down Expand Up @@ -239,7 +239,7 @@ describe("pagination", () => {
});
});

it(".paginate() with results namespace (GET /installation/repositories)", () => {
it.skip(".paginate() with results namespace (GET /installation/repositories)", () => {
nock("https://api.github.com")
.get("/installation/repositories")
.query({
Expand Down Expand Up @@ -343,7 +343,7 @@ describe("pagination", () => {
});
});

it(".paginate() with results namespace (GET /installation/repositories, single page response)", () => {
it.skip(".paginate() with results namespace (GET /installation/repositories, single page response)", () => {
nock("https://api.github.com")
.get("/installation/repositories")
.query({
Expand All @@ -368,7 +368,7 @@ describe("pagination", () => {
});
});

it("does not paginate non-paginated response with total_count property", () => {
it.skip("does not paginate non-paginated response with total_count property", () => {
nock("https://api.github.com")
.get("/repos/octokit/rest.js/commits/abc4567/status")
.reply(200, {
Expand Down
Loading