fix: remove roleb hardcoded namespace and create dedicated sa for the…

… cleanup
odigos-io · Jul 17, 2024 · 80f1c74 · 80f1c74
1 parent 99b98af
commit 80f1c74
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/charts/odigos/templates/cleanup/cleanup-job.yaml b/charts/odigos/templates/cleanup/cleanup-job.yaml
@@ -12,6 +12,7 @@ spec:
   backoffLimit: 0
   template:
     spec:
+      serviceAccountName: cleanup-sa
       containers:
       - name: cleanup
         {{- if .Values.imagePrefix }}

diff --git a/charts/odigos/templates/cleanup/cleanup-rolebinding.yaml b/charts/odigos/templates/cleanup/cleanup-rolebinding.yaml
@@ -4,8 +4,8 @@ metadata:
   name: cleanup-clusterrolebinding
 subjects:
 - kind: ServiceAccount
-  name: default
-  namespace: odigos-system
+  name: cleanup-sa
+  namespace: {{ .Release.Namespace }}
 roleRef:
   kind: ClusterRole
   name: cleanup-clusterrole

diff --git a/charts/odigos/templates/cleanup/service-account.yaml b/charts/odigos/templates/cleanup/service-account.yaml
@@ -0,0 +1,5 @@
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+  name: cleanup-sa
+  namespace: {{ .Release.Namespace }}