Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove roleb hardcoded namespace and create dedicated sa for the… #101

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/odigos/templates/cleanup/cleanup-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ spec:
backoffLimit: 0
template:
spec:
serviceAccountName: cleanup-sa
containers:
- name: cleanup
{{- if .Values.imagePrefix }}
Expand Down
4 changes: 2 additions & 2 deletions charts/odigos/templates/cleanup/cleanup-rolebinding.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ metadata:
name: cleanup-clusterrolebinding
subjects:
- kind: ServiceAccount
name: default
namespace: odigos-system
name: cleanup-sa
namespace: {{ .Release.Namespace }}
roleRef:
kind: ClusterRole
name: cleanup-clusterrole
Expand Down
5 changes: 5 additions & 0 deletions charts/odigos/templates/cleanup/service-account.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
apiVersion: v1
kind: ServiceAccount
metadata:
name: cleanup-sa
namespace: {{ .Release.Namespace }}