Skip to content

Commit

Permalink
Merge branch 'main' into nginx_logs_remove
Browse files Browse the repository at this point in the history
  • Loading branch information
yodigos authored Sep 29, 2024
2 parents 615fafe + 7a84a2d commit e512336
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 25 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ jobs:
cluster_name: kind

- name: Install FE
# this is used for cypress tests which are not run in every scenario
if: matrix.test-scenario == 'multi-apps' || matrix.test-scenario == 'helm-chart' || matrix.test-scenario == 'fe-synthetic'
run: |
cd frontend/webapp
yarn install
Expand Down
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ build-ui:

.PHONY: build-images
build-images:
make -j 3 build-autoscaler build-scheduler build-odiglet build-instrumentor build-collector build-ui TAG=$(TAG)
# prefer to build timeconsuimg images first to make better use of parallelism
make -j 3 build-ui build-collector build-odiglet build-autoscaler build-scheduler build-instrumentor TAG=$(TAG)

.PHONY: push-odiglet
push-odiglet:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// DetectedContainers.tsx
import { KeyvalText } from '@/design.system';
import theme from '@/styles/palette';
import { Condition } from '@/types';
import React from 'react';
import styled from 'styled-components';

Expand All @@ -13,6 +14,7 @@ interface Language {

interface DetectedContainersProps {
languages: Language[];
conditions: Condition[];
}

const Container = styled.div`
Expand All @@ -34,9 +36,9 @@ const ListItem = styled.li`

const DetectedContainers: React.FC<DetectedContainersProps> = ({
languages,
conditions,
}) => {
// Find the first language that is not ignored

const hasError = conditions.some((condition) => condition.status === 'False');
return (
<Container>
<KeyvalText size={18} weight={600}>
Expand All @@ -57,11 +59,10 @@ const DetectedContainers: React.FC<DetectedContainersProps> = ({
? `, Runtime: ${lang.runtime_version}`
: ''}
)
<b>
{lang.language !== 'ignore' &&
lang.language !== 'unknown' &&
' - Instrumented'}
</b>
{lang.language !== 'ignore' &&
lang.language !== 'unknown' &&
!hasError &&
' - Instrumented'}
</KeyvalText>
</ListItem>
))}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ export function CreateConnectionForm({
<KeyvalLoader width={9} height={9} />
) : isConnectionTested.enabled === null ? (
<KeyvalText color={theme.text.secondary} size={14} weight={600}>
{'Check Connection'}
{'Test Connection'}
</KeyvalText>
) : isConnectionTested.enabled ? (
<KeyvalText color={theme.colors.success} size={14} weight={600}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const ITEMS = [
{
id: 'payload-collection',
title: 'Payload Collection',
description: 'Collect payloads from logs, metrics, and traces.',
description: 'Record operation payloads as span attributes where supported.',
type: InstrumentationRuleType.PAYLOAD_COLLECTION,
icon: InstrumentationRuleType.PAYLOAD_COLLECTION,
},
Expand Down
3 changes: 3 additions & 0 deletions frontend/webapp/containers/main/sources/edit.source/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ export function EditSourceForm() {
languages={
currentSource.instrumented_application_details.languages || []
}
conditions={
currentSource.instrumented_application_details.conditions
}
/>
<FieldWrapper>
<KeyvalInput
Expand Down
15 changes: 0 additions & 15 deletions tests/e2e/workload-lifecycle/02-assert-workload-update.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
deployment.kubernetes.io/revision: "2"
generation: 2 # on step 2, the manifest was updated
labels:
app: nodejs-unsupported-version
Expand All @@ -28,8 +26,6 @@ status:
apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
deployment.kubernetes.io/revision: "4"
generation: 4 # step 02 updates the manifest (2->3), then odigos update it again (3->4)
labels:
app: nodejs-very-old-version
Expand Down Expand Up @@ -57,8 +53,6 @@ status:
apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
deployment.kubernetes.io/revision: "4"
generation: 4 # step 02 updates the manifest (2->3), then odigos update it again (3->4)
labels:
app: nodejs-minimum-version
Expand All @@ -85,8 +79,6 @@ status:
apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
deployment.kubernetes.io/revision: "4"
generation: 4 # step 02 updates the manifest (2->3), then odigos update it again (3->4)
labels:
app: nodejs-latest-version
Expand All @@ -113,8 +105,6 @@ status:
apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
deployment.kubernetes.io/revision: "4"
generation: 4 # step 02 updates the manifest (2->3), then odigos update it again (3->4)
labels:
app: nodejs-dockerfile-env
Expand Down Expand Up @@ -144,8 +134,6 @@ status:
apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
deployment.kubernetes.io/revision: "4"
generation: 4 # step 02 updates the manifest (2->3), then odigos update it again (3->4)
labels:
app: nodejs-manifest-env
Expand Down Expand Up @@ -175,8 +163,6 @@ status:
apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
deployment.kubernetes.io/revision: "2"
generation: 2 # on step 2, the manifest was updated (1->2)
labels:
app: cpp-http-server
Expand All @@ -203,7 +189,6 @@ apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
deployment.kubernetes.io/revision: "4"
(odigos.io/manifest-env-original-val == null): true
generation: 5 # started as 2, updated by test once, then by instrumentor and again after new runtime details updated
labels:
Expand Down

0 comments on commit e512336

Please sign in to comment.