feat: Collect Language Version in Runtime #1434
Conversation
blumamir
changed the title
procdiscovery/pkg/process/process.go
Outdated
| const JavaVersionConst = "JAVA_VERSION" | ||
|
|
||
| // envDetailsSeparatorMap is a map of environment variables and their separators | ||
| var envDetailsSeparatorMap = []string{NodeVersionConst, PythonVersionConst, JavaVersionConst} |
There was a problem hiding this comment.
🤔 this is a slice not a map
There was a problem hiding this comment.
haha, yeah it was a map and I changed it to a slice, forgot to change the name
procdiscovery/pkg/process/process.go
Outdated
| } | ||
|
|
||
| for _, env := range envDetailsSeparatorMap { |
There was a problem hiding this comment.
Consider converting envDetailsSeparatorMap from slice to map[strings]struct{}
This way you can look directly the keys instead of iterating the map every time
| envs = make([]odigosv1.EnvVar, 0, len(inspectProc.Environments.OverwriteEnvs)) | ||
| for envName, envValue := range inspectProc.Environments.OverwriteEnvs { | ||
|
|
There was a problem hiding this comment.
This will panic if getRelevantEnvVars returns nil
|
I don't think this is a good fix for the nil issue. |
yodigos
force-pushed
the
runtime_lang_version
branch
from
cf407a1
to
0e8f27f
Compare
| @@ -10,12 +10,34 @@ import ( | |||
| "github.com/odigos-io/odigos/common/envOverwrite" | |||
| ) | |||
|
|
|||
| const NodeVersionConst = "NODE_VERSION" | |||
| const PythonVersionConst = "PYTHON_VERSION" | |||
| const JavaVersionConst = "JAVA_VERSION" | |||
There was a problem hiding this comment.
I think these should be defined per language and not here
| const PythonVersionConst = "PYTHON_VERSION" | ||
| const JavaVersionConst = "JAVA_VERSION" | ||
|
|
||
| // envDetailsMap is a map of environment variables and their separators |
There was a problem hiding this comment.
| // envDetailsMap is a map of environment variables and their separators | |
| // envDetailsMap is a map of environment variables used to discover additional details on the runtime |
No description provided.