Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup overwritten envs when language changes #1546

Merged
merged 4 commits into from
Sep 26, 2024
Merged

fix: cleanup overwritten envs when language changes #1546

merged 4 commits into from
Sep 26, 2024

Conversation

blumamir
Copy link
Collaborator

@blumamir blumamir commented Sep 25, 2024 •
edited
Loading

Handle few edge cases for env overwriter:

  1. if language changes from something to unknown/ignored -> we must cleanup any env variables which were injected for the previous language, to sync them with the resource in use.
  2. cleanup the env overwirtter annotation when it is empty
  3. add e2e scenario to reproduce this case and verify it's behavior

@blumamir blumamir merged commit 5ede468 into odigos-io:main Sep 26, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonFed RonFed RonFed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blumamir @RonFed