Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Nginx stop logs #1556

Merged
merged 2 commits into from
Sep 29, 2024
Merged

feat: Nginx stop logs #1556

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
615fafe
Nginx stop logs
yodigos Sep 29, 2024
e512336
Merge branch 'main' into nginx_logs_remove
yodigos Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion instrumentor/instrumentation/instrumentation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func ApplyInstrumentationDevicesToPodTemplate(original *corev1.PodTemplateSpec,
var modifiedContainers []corev1.Container
for _, container := range original.Spec.Containers {
containerLanguage := getLanguageOfContainer(runtimeDetails, container.Name)
if containerLanguage == nil || *containerLanguage == common.UnknownProgrammingLanguage || *containerLanguage == common.IgnoredProgrammingLanguage {
if containerLanguage == nil || *containerLanguage == common.UnknownProgrammingLanguage || *containerLanguage == common.IgnoredProgrammingLanguage || *containerLanguage == common.NginxProgrammingLanguage {
// always patch the env vars, even if the language is unknown or ignored.
// this is necessary to sync the existing envs with the missing language if changed for any reason.
err = patchEnvVarsForContainer(runtimeDetails, &container, nil, *containerLanguage, manifestEnvOriginal)
Expand Down
Loading