Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removing leader election from instrumentor/scheduler/autoscaler #1580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tamirdavid1
Copy link
Collaborator

When the API server is slow or unresponsive, services configured with leader election may encounter errors like this:

2024-10-07T21:59:35Z	ERROR	setup	problem running manager	{"error": "leader election lost"}
main.main
	/workspace/scheduler/main.go:122
runtime.main
	/usr/local/go/src/runtime/proc.go:271

What is leader election?
Leader election in Kubernetes is a process where one instance of a component (such as a controller) is selected to act as the "leader" and perform certain tasks, while other instances remain idle. This mechanism ensures that only one instance manages a resource at a time, preventing conflicts. If the leader fails or becomes unavailable, a new leader is elected, ensuring high availability.

In Odigos, these components not scale, no handoffs needed in case one pod is down and we can avoid above errors with removing this.
To make it easier to re-enable, I keep the flag controlling it at the top of each main file for convenience.

Copy link
Contributor

@edeNFed edeNFed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants