Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update qryn+gigapipe docs #1594
Update qryn+gigapipe docs #1594
Changes from 11 commits
960e0f2
8684e42
5304e3b
fb4437f
ea65fd5
4a86938
8e4079d
98901a4
3339409
11170d1
7f6b3ab
6bfea8b
a64b679
1e62751
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider trimming rawURL white spaces, as it will make
url.Parse(rawURL)
return with error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
important: if we encode the secret into the url this way, it will show up as plain text in the config map which can be undesirable for some users due to security concerns.
You can use the
basicauthextension
to implement this authentication, while keeping the password as env variable. seeotlphttp
for example code on how to use itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: after the latest commit, the value is no longer plain text in the configmap which is great.
If you like, you can still consider using the basic auto extension, or resolve this thread.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we just take the
u.Host
, we will silently drop anyu.Path
that the user might have set. I guess in most cases this is fine, but in clusters with internal routing this might break the export.I am also fine with keeping it as is if you prefer and address this issue if someone bumps into it.
An alternative can be to modify the
u
object itself, and then useu.String()
to make it a safe url string in idomatic wayThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on the usage for this exporter name?
I see it adds an attribute
"qryn_exporter"
to all telemetry signals with valuesodigos-qryn-logs
,odigos-qryn-traces
,odigos-qryn-metrics
.Is this added to trace in qryn where the data came from?
Is
qryn_exporter
a common attribute inqryn
ecosystem?