chore(scheduler): use instrumentation config instead of application #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
reviewed
Oct 20, 2024
| return ctrl.Result{}, err | ||
| } | ||
| numberOfInstrumentedApps := len(instrumentedApps.Items) | ||
| numberOfInstrumentedApps := len(instrumentedConfigs.Items) |
There was a problem hiding this comment.
numberOfInstrumentedApps -> numberOfInstrumentationConfigs
There was a problem hiding this comment.
It's intentional. Each instrumentation config object represents an app
RonFed
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the scheduler component to use
instrumentationconfigsinstead ofinstrumentedapplications. There is an effort to merge them any only use one CRD - theinstrumentationconfigs.The content of the object is not examined, it only checks if we have any
instrumentationconfigsor not. Thus it should be safe.