Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[atspi-common] ObjectPair in EventBodyQT #114

Merged
merged 9 commits into from
Jul 19, 2023
Merged

[atspi-common] ObjectPair in EventBodyQT #114

merged 9 commits into from
Jul 19, 2023

Conversation

luukvanderduim
Copy link
Collaborator 

This builds on the 'remove-object-pairs' branch.

- replaces the (String, OwnedPath) with an `Accessible` in `EventBodyQT`
- adjusts the conversion to `EventBodyOwned`
- adjusts `test_event_body_qt_to_event_body_owned_conversion`
  because the defaults and the assumed values in the test no longer matched.

TTWNO and others added 8 commits July 10, 2023 20:04
@TTWNO @luukvanderduim
Accessible.name from OwnedUniqueName to String; this is the type sent…
7280a5d 
… over the bus
@TTWNO @luukvanderduim
Move Accessible into its own module
20ec11b
@TTWNO @luukvanderduim
Switch all references of ObjectPath to Accessible
d01daee
@TTWNO @luukvanderduim
Change all ObjectPair/(String, OwnedObjectPath) to Accessible
d9d14f1
@TTWNO @luukvanderduim
Cargo format
1d770c3
@TTWNO @luukvanderduim
Remove Accessible signature test, since it is now in its own accessib…
cc5f4a4 
…le module
@luukvanderduim
[atspi-common] ObjectPair in EventBodyQT
ae88233 
This:
- replaces the (String, OwnedPath) with an `Accessible` in `EventBodyQT`
- adjusts the conversion to `EventBodyOwned`
- adjusts `test_event_body_qt_to_event_body_owned_conversion`
  because the defaults and the assumed values in the test no longer matched.
@luukvanderduim
[atspi-common] Add tests on Accessible
23904e0 
Adds:

test_accessible_from_dbus_ctxt_to_accessible
test_accessible_value_wrapped_from_dbus_ctxt_to_accessible

Also, I took the liberty of moving the `Default` and the singature test upward.
Especially the default implementation is something one would like to reference
while seeing the type.
Base automatically changed from remove-object-pairs to main July 14, 2023 01:43
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #114 (ea78420) into main (ac7cf05) will increase coverage by 0.09%.
The diff coverage is 98.18%.

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   90.62%   90.71%   +0.09%     
==========================================
  Files          39       39              
  Lines        3028     3060      +32     
==========================================
+ Hits         2744     2776      +32     
  Misses        284      284
Impacted Files Coverage Δ
atspi-common/src/accessible.rs 95.31% <97.82%> (+4.40%) ⬆️
atspi-common/src/events/mod.rs 89.97% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TTWNO
Copy link
Member

TTWNO commented Jul 19, 2023

LGTM!

@TTWNO TTWNO merged commit 877735b into main Jul 19, 2023
11 of 12 checks passed
@TTWNO TTWNO deleted the remove-object-pairs-ext branch July 19, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luukvanderduim @TTWNO