Make ObjectRef more explicit in type #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataTriny
requested changes
Apr 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 84.07% 84.14% +0.07%
==========================================
Files 39 39
Lines 3083 3097 +14
==========================================
+ Hits 2592 2606 +14
Misses 491 491 ☔ View full report in Codecov by Sentry. |
DataTriny
approved these changes
Apr 18, 2024
Addressed by #179 , where I've already requested a review from Luuk, but I'd appreciate a look from yourself as well. |
|
Will try to do it tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ObjectRef more explicit in that the "name" refers to a
zbus_names::BusName, and not just any String.