Added warning on accidental exit #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? Also need an authorization to run tests. |
Closed
wbrunette
requested changes
Apr 16, 2022
| }) | ||
| .setNegativeButton("No", null) | ||
| .show(); | ||
| //popBackStack(); |
There was a problem hiding this comment.
I do not believe this solution will work. As the back stack tracks the screens that have been rendered in the WebUI. By commenting out popBackStack() you are changing the way Tables is designed to operate.
The warning should only happen when there is nothing left on the back stack. Otherwise it should bring up the other back stack entry. Check out line 265 as that is the case when finish is getting called because there is nothing left on the backStack
|
I got your point, @wbrunette. I've committed the changes. So, can you please review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue: odk-x/tool-suite-X#129