Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODK-X Services - Set the status bar color #366

Open
maprehensive opened this issue Oct 2, 2022 · 39 comments
Open

ODK-X Services - Set the status bar color #366

maprehensive opened this issue Oct 2, 2022 · 39 comments

Comments

@maprehensive
Copy link
Contributor

maprehensive commented Oct 2, 2022

Set the color of the app status bar to match the app background color in ODK-X Services.

Screen Shot 2022-10-02 at 09 40 09
Example of the default status bar color (left) and status bar color changed to match the app background (right)

Why this needs to be improved:

  • the menu bar in the application looks crowded by the default grey status bar

Guidance for this issue:

  • Change settings in styles.xml or theme.xml
  • Light mode: <item name="android:navigationBarColor" tools:targetApi="21">@color/white</item>
  • For dark mode see design guidelines below

Guidelines:

This issue is referenced on slide 12 of the ODK-X Design Guidelines

Outreachy

This issue can be used for an Outreachy application for the project Custom UI components for ODK-X mobile apps
This issue is for the Technical stream of the project.

Please request to be assigned to the issue so we can track the number of peopling doing this exercise. Multiple people can work on this issue simultaneously.

You do not need to be assigned to this issue to work on it for an Outreachy application

@Redeem-Grimm-Satoshi
Copy link
Member

@maprehensive can I work on this task?

@phelisa1
Copy link

phelisa1 commented Oct 8, 2022

@maprehensive I would love to work on this task. May I please get permission to work on it?

@kryptosjay
Copy link

I would love to work on this project if i will be granted access to the task, thank you

@maprehensive
Copy link
Contributor Author

@Redeem-Grimm-Satoshi since I've assigned you to #365 I will assign this to the next requester.

@phelisa1 Thanks! You are assigned to this issue.

@maprehensive
Copy link
Contributor Author

@kryptosjay I've assigned you to this issue. Thanks!

@Augusta2
Copy link

Augusta2 commented Oct 9, 2022

Hello @maprehensive I would love to work on this issue

@Hilzygift
Copy link

Hi @maprehensive, I would like to collaborate with other assigned contributors to work on this task.

@ghost
Copy link

ghost commented Oct 11, 2022

Hi @maprehensive I would like to work on this issue. Thanks

@Joyfro
Copy link

Joyfro commented Oct 11, 2022

Hello @maprehensive , I would love to work on this issue.

@Redeem-Grimm-Satoshi
Copy link
Member

Redeem-Grimm-Satoshi commented Oct 11, 2022

So I did some changes.

  1. I used statusBarColor instead of naviagationBarColor ( Tested Locally and it worked )
  2. Added windowsLightStatusBar ( with boolean value: [true] so that status bar doesn't become opaque
  3. Light and Dark theme colors implemented

Please Check PR for this latest modifications.

@Blessing1135
Copy link

Hello@maprehensive, I would love to work on this issue, and I will be glad if the opportunity is given to me. Thank you.

@Augusta2 Augusta2 removed their assignment Oct 13, 2022
@NiranjanNlc
Copy link

Hi , I want to work on this issue, and would be thankful for the opportunity

@Joyfro
Copy link

Joyfro commented Oct 13, 2022

Hello @maprehensive, can you please guide me on how I can work on this issue?. I have forked and cloned the services repository but I can't seem to find any settings, theme.xml , or styles.xml files

@Blessing1135
Copy link

Helo @maprehensive thank you for the opportunity pls I need a.guide on how to go about it

@maprehensive
Copy link
Contributor Author

@NiranjanNlc @Joyfro @Blessing1135 you can work ion this without being assigned.

To get started, check page 12 of the style guide, there are some notes there on the relevant files.

@Coder-For-Life
Copy link

Hello @maprehensive can I work on this?
I need like a guide on how to go about this

@JessicaItepu
Copy link

Hello @maprehensive could you pleasee assign me to this project too? I am excited to jump on it

@Joyfro
Copy link

Joyfro commented Oct 14, 2022

@maprehensive I have resolved this issue and created a pull request. odk-x/services#250
Also tested on my android emulator and it worked. please see screenshots below:

android studio

@NiranjanNlc
Copy link

@NiranjanNlc @Joyfro @Blessing1135 you can work ion this without being assigned.

To get started, check page 12 of the style guide, there are some notes there on the relevant files.

Hey @maprehensive , I have resolved the issuse and created a pull request to address it .
Please review it .
I have verified both the light mode and dark mode in my device . Please refer the screenshot below .

@Coder-For-Life
Copy link

@maprehensive I'm confused, are we supposed to use a specific language or any language of our choice?

@maprehensive
Copy link
Contributor Author

@maprehensive I'm confused, are we supposed to use a specific language or any language of our choice?

@Coder-For-Life you can make the required changes in Android Studio in the theme files. There was some instruction in a link in the issue description, and some notes from other contributors.

See if reading back through those comments and reviewing other contributions helps.

@maprehensive
Copy link
Contributor Author

Hello @maprehensive could you pleasee assign me to this project too? I am excited to jump on it

No need to be assigned - you can go ahead and work on it!

@Blessing1135
Copy link

@maprehensive Trust you are good? Thank you so much for the opportunity, however I have a question regarding the issue, must this changes be made using the android Studio or one can use figma? I am very new to these and I need help. Thank you.

@Cveman1
Copy link
Member

Cveman1 commented Oct 17, 2022

Hi @Blessing1135, some issues have descriptions that tell whether it is technical or for the UI stream of the applicants. Although I stand to be corrected, the technical stream is for the Android developers while the design is for the UI designers:

See here:
image

@maprehensive
Copy link
Contributor Author

@Blessing1135 the changes for this issue would need to be made using Android Studio.

Thanks @Cveman1 !

@Rubadel
Copy link

Rubadel commented Oct 19, 2022

@maprehensive Hello Dear,
I see that more of one worked on this task, Is it okay? Can I work on what I issue want without worry if another one get worked on it before me ?

@maprehensive
Copy link
Contributor Author

maprehensive commented Oct 19, 2022 via email

@wadva474
Copy link

@maprehensive , i have created PR to address themes generally in ODX- applications (Services, Survey and Tables)
The following PR's address the issues

Thanks.

@NiranjanNlc
Copy link

Hey @maprehensive , based on the feedback received from @wbrunette i have updated the following pr on android libary followed by the pr on service repo to address the issuse .

Please review and let us know .

Thanks .

@JessicaItepu
Copy link

Hello @maprehensive, I have created a Pull request addressing the status bar icons in all the odk apps. I have also included screenshots of my android emulator running each app. Thank you.

@Blessing1135
Copy link

@maprehensive Good day and thank you for always having time to respond to me, I am not taking this for granted, Yes I asked for an avenue on how to change the status of the odk-x service bar color I was told the changes have to be made via Android Studio though I went to figma to work on a similar thing before I asked, however, I downloaded the android Studio and been trying to understand it better which I think I am beginning to but I am having difficulty whenever I tried to clone the repository on android studio. the error message of clone fail keeps popping out, Please I need help as to what next to do I am willing to learn. Thank you.

@Redeem-Grimm-Satoshi
Copy link
Member

Redeem-Grimm-Satoshi commented Oct 24, 2022 via email

@Blessing1135
Copy link

Screenshot (104)

@Redeem-Grimm-Satoshi Thank you for the reply, here is the screenshot.

@Redeem-Grimm-Satoshi
Copy link
Member

Redeem-Grimm-Satoshi commented Oct 25, 2022 via email

@Blessing1135
Copy link

Thank you @Redeem-Grimm-Satoshi would you mind helping out with the process to be taken? This is my very first time doing this please.

@Redeem-Grimm-Satoshi
Copy link
Member

@Blessing1135 , Go through this: Setting Up ODK-X Dev Environment

@Redeem-Grimm-Satoshi
Copy link
Member

It's going to help you understand which repositories you'll be cloning and how to structure them correctly.

@Nilakshisute
Copy link

Hey @maprehensive i would like to work on this task. Kindly assign this to me.

@PASEDA-MODUPE
Copy link

hello @ @maprehensive i would love to work on this task
pls assign to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment