Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FIX] web: <details> visiblity check regression in Chromium 97+
Since Chromium 97, folded `<details>` content has non-zero computed width and height which returns false-positive QUnit `assert.isNotVisible()` calls. In a nutshell, this was introduced in https://bugs.chromium.org/p/chromium/issues/detail?id=1185950 when Chromium implemented the ability for "Find in page" to search in folded `<details>`. To do so, the `content-visibility` rule was used instead of `display: none` which, even if functionally similar, has an impact on the values returned by `getBoundingClientRect()` (i.e. used in `assert.isNotVisible()`. A regression report was filled in https://bugs.chromium.org/p/chromium/issues/detail?id=1276028 to highlight this change of behavior. What emerged from this report's discussion is that Chromium has no intent to revert this change and instead put the emphasis on avoiding to use `getBoundingClientRect()` and similar methods for visibility check (even pushing a proposal for a `Element.isVisible()` API; cf. w3c/csswg-drafts#6850). This commit works around this issue by forcing the content to `display: none`, like in the previous Chromium versions. closes odoo#91649 X-original-commit: 5aa2a71 Signed-off-by: Aaron Bohy (aab) <[email protected]> Signed-off-by: Pierre Paridans (app) <[email protected]>
- Loading branch information