-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add highest/lowest mmr matches #712
Conversation
howardchung
commented
Feb 16, 2017
- splits matches list into 3 tabs: pro, high mmr, low mmr
Is there easy way to get heroes for matches? Would be cool. |
Like the hero IDs of the heroes in the match? |
Yes |
We could change the ingestion to store the hero_ids in new columns (one per team), but that requires a core/schema change. I'm not sure if it's possible to use some joins or something to fetch the hero IDs into the match row. |
Might be possible with this: http://stackoverflow.com/questions/43870/how-to-concatenate-strings-of-a-string-field-in-a-postgresql-group-by-query I'll give it a shot! |
The above isn't working well since the joins to the tables with the radiant/dire team hero_ids is not subject to the WHERE clause of the main query, so it's assembling the subqueries for the entire table of public_player_matches. |
Actually, the following seems to work, although it's kinda messy:
|