Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PublicationPlots do not check for non-finite data #737

Closed
odow opened this issue Mar 22, 2024 · 2 comments · Fixed by #738
Closed

PublicationPlots do not check for non-finite data #737

odow opened this issue Mar 22, 2024 · 2 comments · Fixed by #738

Comments

@odow
Copy link
Owner

odow commented Mar 22, 2024

From an un-named person on WhatsApp:

image
@bernardokp
Copy link

Thanks for the suggestion.

Signed: Unknown person

@odow
Copy link
Owner Author

odow commented Mar 22, 2024

We'd need to check the finiteness in

SDDP.jl/src/visualization/publication_plot.jl

Lines 16 to 17 in 6609655

stage_data = stage_function.([data[stage] for data in dataset])
output_array[:, stage] .= Statistics.quantile(stage_data, quantiles)

But I think we should still accept NaN. So just +-Inf.

@odow odow mentioned this issue Apr 30, 2024
Merged
@odow odow closed this as completed in #738 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a test for non-finite data in publication_plot odow/SDDP.jl
2 participants
@odow @bernardokp