Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for non-finite data in publication_plot #738

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Add a test for non-finite data in publication_plot #738

merged 4 commits into from
Apr 30, 2024

Conversation

odow
Copy link
Owner

@odow odow commented Apr 30, 2024

Closes #737

Also errors on NaN because:

julia> quantile([1, NaN, 2], 0.5)
ERROR: ArgumentError: quantiles are undefined in presence of NaNs or missing values
Stacktrace:
 [1] _quantilesort!(v::Vector{Float64}, sorted::Bool, minp::Float64, maxp::Float64)
   @ Statistics ~/.julia/juliaup/julia-1.10.2+0.x64.apple.darwin14/share/julia/stdlib/v1.10/Statistics/src/Statistics.jl:994
 [2] quantile!(v::Vector{Float64}, p::Float64; sorted::Bool, alpha::Float64, beta::Float64)
   @ Statistics ~/.julia/juliaup/julia-1.10.2+0.x64.apple.darwin14/share/julia/stdlib/v1.10/Statistics/src/Statistics.jl:976
 [3] quantile!
   @ ~/.julia/juliaup/julia-1.10.2+0.x64.apple.darwin14/share/julia/stdlib/v1.10/Statistics/src/Statistics.jl:976 [inlined]
 [4] quantile(v::Vector{Float64}, p::Float64)
   @ Statistics ~/.julia/juliaup/julia-1.10.2+0.x64.apple.darwin14/share/julia/stdlib/v1.10/Statistics/src/Statistics.jl:1089
 [5] top-level scope
   @ REPL[10]:1

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (6609655) to head (fcb134e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
- Coverage   93.43%   93.38%   -0.06%     
==========================================
  Files          27       27              
  Lines        3410     3414       +4     
==========================================
+ Hits         3186     3188       +2     
- Misses        224      226       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit 8ed2e30 into master Apr 30, 2024
7 of 8 checks passed
@odow odow deleted the od/pubplot branch April 30, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PublicationPlots do not check for non-finite data
1 participant