Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs redux Part II #135

Merged
merged 8 commits into from
Jun 9, 2018
Merged

Docs redux Part II #135

merged 8 commits into from
Jun 9, 2018

Conversation

odow
Copy link
Owner

@odow odow commented Jun 8, 2018

Tick once addressed:

Ref #34, #130 #133

@codecov
Copy link

codecov bot commented Jun 8, 2018

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files          29       29           
  Lines        1375     1375           
=======================================
  Hits         1234     1234           
  Misses        141      141
Impacted Files Coverage Δ
src/solve_asynchronous.jl 81.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a674637...8ad02ae. Read the comment docs.

end)

@rhsnoise(sp, ω = [0.9, 1.0, 1.1], inflow_noise_term == ω)
@NLconstraint(sp, log(inflow′) == log(inflow) + log(inflow_noise_term))
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also cc @Thuener. I just realized you can include logs in the constraints if you use Ipopt. Haven't checked how fast it is but it works as proof of concept.

@odow odow merged commit f278703 into master Jun 9, 2018
@odow odow deleted the docs branch June 9, 2018 03:11
This was referenced Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant