Updated hydro valley example and tests #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 93.73% 93.81% +0.08%
==========================================
Files 14 14
Lines 1229 1229
==========================================
+ Hits 1152 1153 +1
+ Misses 77 76 -1
Continue to review full report at Codecov.
|
odow
reviewed
Jul 15, 2019
There was a problem hiding this comment.
Great! So the tests probably pass because it ignores everything in the sddp.jl_not_updated folder. Move these examples into the main examples folder and then re-run the tests to see what breaks.
In addition, take a look at the other examples. We wrap everything in a function so we're not polluting the global namespace with lots of different models lying around.
examples/sddp.jl_not_updated/HydroValleys/hydro_valley_tests.jl
Outdated
Show resolved
Hide resolved
odow
approved these changes
Jul 18, 2019
|
Thanks @conrad-mac! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Oscar,
I had a go at updating the hydro valley example as an exercise in getting better acquainted with Julia/JuMP/SDDP. I'm still learning so it may not be terribly elegant. I followed your upgrading guide and managed to get there in the end. The tests all seem to pass.
Cheers,
Conrad