Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom_recorders example #245

Merged
merged 1 commit into from
Aug 24, 2019
Merged

Fix custom_recorders example #245

merged 1 commit into from
Aug 24, 2019

Conversation

Thuener
Copy link
Collaborator

@Thuener Thuener commented Aug 23, 2019

No description provided.

@odow
Copy link
Owner

odow commented Aug 23, 2019

Thanks! We should probably make these doctests to avoid these errors.

@odow
Copy link
Owner

odow commented Aug 23, 2019

So the doc failure on Travis isn't your fault. But I'm not sure of the cause. Might be a documenter issue?

@Thuener
Copy link
Collaborator Author

Thuener commented Aug 24, 2019

Maybe is the "open = true"?

@odow
Copy link
Owner

odow commented Aug 24, 2019

I can't reproduce this locally. #244 is incoming with a fix, but it might conflict with this, so I'll merge now and deal with the consequences in #244.

@odow odow merged commit 5e0b0fd into odow:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odow odow odow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thuener @odow