Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] clarify simulate using a different sampling scheme #692

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

odow
Copy link
Owner

@odow odow commented Sep 29, 2023

Closes #691

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1050457) 92.74% compared to head (abc49ca) 92.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #692   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files          27       27           
  Lines        3351     3351           
=======================================
  Hits         3108     3108           
  Misses        243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Owner Author

odow commented Sep 29, 2023

cc @HenriDeh is this any better:

https://sddp.dev/previews/PR692/guides/simulate_using_a_different_sampling_scheme/

I've added

# Note: `Ω` is defined at the top of this page of documentation

in places

@HenriDeh
Copy link

HenriDeh commented Oct 1, 2023

Yes totally. It will help people like me who tunnel-vision save some time :)

@odow odow merged commit 5369258 into master Oct 3, 2023
9 checks passed
@odow odow deleted the od/docs-sampling-scheme branch October 3, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined variable in out-of-sample-sampling documentation
2 participants