Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing additionalProperties entity GlossaryTerm in OMAS Subject-Area #5810

Closed
1 task done
Inventoroz opened this issue Oct 8, 2021 · 5 comments · Fixed by #5916
Closed
1 task done

[BUG] Missing additionalProperties entity GlossaryTerm in OMAS Subject-Area #5810

Inventoroz opened this issue Oct 8, 2021 · 5 comments · Fixed by #5916
Assignees
Labels
bug Something isn't working triage New bug/issue which needs checking & assigning

Comments

@Inventoroz
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

in Request Object exist additionalProperties
but in Response Object additionalProperties is absent

POST https://1.2.3.4:9443/servers/xxx/open-metadata/access-services/subject-area/users/admin/terms

{
"class" : "Term",
"nodeType" : "Term",
"name" : "Term Test Name 0.5748931709211221",
"readOnly" : false,
"additionalProperties" : {
"today" : "1633689021318"
},
"glossary" : {
"type" : "Glossary",
"guid" : "5e305954-5aee-4cac-b65b-4eff606860fd"
},
"spineObject" : false,
"spineAttribute" : false,
"objectIdentifier" : false
}
200 OK
{
"class" : "SubjectAreaOMASAPIResponse",
"relatedHTTPCode" : 200,
"result" : [ {
"class" : "Term",
"nodeType" : "Term",
"name" : "Term Test Name 0.5748931709211221",
"qualifiedName" : "Term Test Name 0.5748931709211221@4ab66c39-978d-4d95-a3a6-535ac3cacdfe",
"systemAttributes" : {
"status" : "ACTIVE",
"createdBy" : "admin",
"createTime" : 1633688996635,
"version" : 1,
"guid" : "60a50022-9e71-4d9e-a633-d525dd6440d2"
},
"readOnly" : false,
"glossary" : {
"type" : "Glossary",
"name" : "Glossary Test 0.4801305388788021",
"qualifiedName" : "Glossary Test 0.4801305388788021@c90c4dae-94e6-4b00-8cf1-d12a66fc1401",
"guid" : "5e305954-5aee-4cac-b65b-4eff606860fd",
"relationshipguid" : "1a23d392-ae9b-4f41-a2d6-d9ce28420643"
},
"spineObject" : false,
"spineAttribute" : false,
"objectIdentifier" : false
} ]
}

Expected Behavior

in Response Object

"additionalProperties" : {
"today" : "1633689021318"
},

Steps To Reproduce

Create Term in OMAS Subject-Area with property "additionalProperties"

Environment

- Egeria: 3.2
- OS: CentOS 7
- Java: 11

Any Further Information?

No response

@Inventoroz Inventoroz added bug Something isn't working triage New bug/issue which needs checking & assigning labels Oct 8, 2021
@Inventoroz
Copy link
Author

I suspect that there is a problem in the formation of the GlossaryTermBuilder to which information about additionalProperties from the suppliedTerm is not transmitted

@Inventoroz
Copy link
Author

Inventoroz commented Nov 4, 2021

@davidradl, Is there any movement on the issue?

@davidradl
Copy link
Member

@Inventoroz sorry I have not got to this -and am unlikely to get to it near term. Do you want to have a look at it?

@davidradl
Copy link
Member

@Inventoroz I will try to get to this, this week.

@davidradl
Copy link
Member

From a quick look we should be using the GlossaryTermBuilder that accepts all the parameters including additionalProperties.

davidradl added a commit to davidradl/egeria that referenced this issue Nov 9, 2021
davidradl added a commit to davidradl/egeria that referenced this issue Nov 9, 2021
davidradl added a commit to davidradl/egeria that referenced this issue Nov 9, 2021
davidradl added a commit to davidradl/egeria that referenced this issue Nov 11, 2021
davidradl added a commit that referenced this issue Nov 11, 2021
#5810 support additionParameters for Terms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage New bug/issue which needs checking & assigning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants