Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third-party technology integration clean-up #5344

Merged
merged 12 commits into from
Jun 11, 2021

Conversation

lpalashevski
Copy link
Contributor

@lpalashevski lpalashevski commented Jun 9, 2021

Changes in this PR:

Ljupcho Palashevski added 4 commits June 8, 2021 16:04
Signed-off-by: Ljupcho Palashevski <[email protected]>
Signed-off-by: Ljupcho Palashevski <[email protected]>
@lpalashevski
Copy link
Contributor Author

lpalashevski commented Jun 9, 2021

Ups, I missed one more reference: cassandra-data-store-connector is used in DataStoreConnectorsArchiveBuilder.

@mandy-chessell Is open-connector-archives module candidate for external repository also?

@lpalashevski lpalashevski marked this pull request as draft June 9, 2021 15:41
@mandy-chessell
Copy link
Contributor

Ups, I missed one more reference: cassandra-data-store-connector is used in DataStoreConnectorsArchiveBuilder.

@mandy-chessell Is open-connector-archives module candidate for external repository also?

I expect it needs to be in the repository where the uber-assembly is. At the moment it is only able to create a connector type archive for the data connectors in the main repository

@planetf1
Copy link
Member

planetf1 commented Jun 9, 2021

Ups, I missed one more reference: cassandra-data-store-connector is used in DataStoreConnectorsArchiveBuilder.
@mandy-chessell Is open-connector-archives module candidate for external repository also?

I expect it needs to be in the repository where the uber-assembly is. At the moment it is only able to create a connector type archive for the data connectors in the main repository

Indeed - we need to figure out what we actually want

If it's a complete filesystem tree (think 'egeria-all' !) , we can certainly do that in a distinct repo, similarly to create a connector archive, but who will use them, and how we need to work through, as well as then what each repo 'delivers'

Signed-off-by: Ljupcho Palashevski <[email protected]>
@lpalashevski lpalashevski self-assigned this Jun 9, 2021
Copy link
Member

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super to have this cleaned up. Looks a very thorough proposal

Can we remove the file DataPlatformServicesConfig.java ? Seems to only be for the admin services for data platform & should be removed?
THis also appears in AdminServicesConfigHeader as

        @JsonSubTypes.Type(value = DataPlatformServicesConfig.class, name = "DataPlatformServicesConfig")

which can be removed

@lpalashevski
Copy link
Contributor Author

lpalashevski commented Jun 10, 2021

Can we remove the file DataPlatformServicesConfig.java ? Seems to only be for the admin services for data platform & should be removed?
THis also appears in AdminServicesConfigHeader as

        @JsonSubTypes.Type(value = DataPlatformServicesConfig.class, name = "DataPlatformServicesConfig")

which can be removed

Initially I had it removed but then put it back beacause there is configuration check in ServerTypeClassifier:

        if (configurationDocument.getDataPlatformServicesConfig() != null)
        {
            throw new OMAGInvalidParameterException(OMAGAdminErrorCode.OLD_CONFIGURATION.getMessageDefinition(serverName,
                                                                                                              configurationDocument.getDataPlatformServicesConfig().toString()),
                                                    this.getClass().getName(),
                                                    methodName);
        }

Let's decide on the call today.

Ljupcho Palashevski added 3 commits June 10, 2021 16:30
@lpalashevski lpalashevski added the third party integration Features or defects for a metadata integration with third party technologies label Jun 10, 2021
@planetf1
Copy link
Member

Suggesting adding a reference to /release-notes/release-notes-2-11.md (see Removed Functionality)

Ljupcho Palashevski added 2 commits June 11, 2021 09:23
@lpalashevski lpalashevski marked this pull request as ready for review June 11, 2021 07:24
@lpalashevski
Copy link
Contributor Author

@planetf1 This is now ready to be merged, please do final check.

@planetf1 planetf1 self-requested a review June 11, 2021 10:28
Copy link
Member

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree these changes are ready to merge

@planetf1 planetf1 merged commit dac1950 into odpi:master Jun 11, 2021
@lpalashevski lpalashevski deleted the tp-integration-cleanup branch October 5, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
third party integration Features or defects for a metadata integration with third party technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants