-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third-party technology integration clean-up #5344
Conversation
Signed-off-by: Ljupcho Palashevski <[email protected]>
Signed-off-by: Ljupcho Palashevski <[email protected]>
Signed-off-by: Ljupcho Palashevski <[email protected]>
Signed-off-by: Ljupcho Palashevski <[email protected]>
Ups, I missed one more reference: cassandra-data-store-connector is used in DataStoreConnectorsArchiveBuilder. @mandy-chessell Is open-connector-archives module candidate for external repository also? |
I expect it needs to be in the repository where the uber-assembly is. At the moment it is only able to create a connector type archive for the data connectors in the main repository |
Indeed - we need to figure out what we actually want If it's a complete filesystem tree (think 'egeria-all' !) , we can certainly do that in a distinct repo, similarly to create a connector archive, but who will use them, and how we need to work through, as well as then what each repo 'delivers' |
Signed-off-by: Ljupcho Palashevski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super to have this cleaned up. Looks a very thorough proposal
Can we remove the file DataPlatformServicesConfig.java ? Seems to only be for the admin services for data platform & should be removed?
THis also appears in AdminServicesConfigHeader as
@JsonSubTypes.Type(value = DataPlatformServicesConfig.class, name = "DataPlatformServicesConfig")
which can be removed
open-metadata-resources/open-metadata-archives/open-connector-archives/pom.xml
Outdated
Show resolved
Hide resolved
Initially I had it removed but then put it back beacause there is configuration check in ServerTypeClassifier:
Let's decide on the call today. |
Signed-off-by: Ljupcho Palashevski <[email protected]>
Signed-off-by: Ljupcho Palashevski <[email protected]>
Suggesting adding a reference to /release-notes/release-notes-2-11.md (see Removed Functionality) |
Signed-off-by: Ljupcho Palashevski <[email protected]>
@planetf1 This is now ready to be merged, please do final check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree these changes are ready to merge
Changes in this PR: