Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMRS REST API nextPageURL #6215

Merged
merged 7 commits into from
Feb 16, 2022
Merged

OMRS REST API nextPageURL #6215

merged 7 commits into from
Feb 16, 2022

Conversation

lpalashevski
Copy link
Contributor

@lpalashevski lpalashevski commented Feb 9, 2022

Description

Scope changed to remove unused functionality #6220

--
Issues discovered while testing with paged results:

  1. nextPageURL returned by OMRS REST API paged responses is invalid due to missing "/" while constructing the URL.
  2. pageSize parameter embedded in the nextPageURL is always 0
  3. Embedded search body should be either URL encoded or (more preferred) we move from body to URL query parameters (suggest triage on the next community call)

Example (as-is):

POST {{base-url}}/servers/{{server-id}}/open-metadata/repository-services/users/{{user-id}}/instances/entity/02f79bdb-3a6c-4824-a672-f9285a62b995/relationships

{
    "class": "TypeLimitedFindRequest",
    "pageSize": 2,
    "offset": 0
}
{
    "class": "RelationshipListResponse",
    "relatedHTTPCode": 200,
    "nextPageURL": "https://localhost:9443admin/instances/entity/02f79bdb-3a6c-4824-a672-f9285a62b995/relationships{{\"class\":\"TypeLimitedFindRequest\",\"offset\":2,\"pageSize\":0}}",
    "offset": 0,
    "pageSize": 2,
    "relationships": [ ... ]
}

Fixes # (issue)
No related issue opened.

How Has This Been Tested?

Local graph repository retrieving paged relationships for entity.

@lpalashevski lpalashevski self-assigned this Feb 9, 2022
@lpalashevski lpalashevski added the triage New bug/issue which needs checking & assigning label Feb 9, 2022
@davidradl davidradl merged commit a2147db into odpi:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage New bug/issue which needs checking & assigning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants