Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side support for external references in Asset Manager OMAS #6354

Merged
merged 18 commits into from
Apr 3, 2022

Conversation

mandy-chessell
Copy link
Contributor

@mandy-chessell mandy-chessell commented Mar 29, 2022

Description

Add the server-side support for the management of external reference entities and external reference links that connect from referenceables to external reference entities

Also made changes to types:

  • ExternalReferenceLink and MediaReference are multi-link relationships
  • New software services for MetadataRepositoryService and SecurityService
  • New relationship SoftwarePackageDependency
  • New VisibleEndpoint relationship
  • Deprecated HostNetwork relationship
  • New properties for NetworkGatewayLink to enable it to represent a specific port mapping. This means NetworkGatewayLink needs to be multi-link
  • SourcedFrom relationship had cardinatiliity defined the wrong way around

Fixes # (issue)

How Has This Been Tested?

Regression tested with FVT and open metadata labs
Will add specific FVTs later

Any additional notes for reviewers?

Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
@mandy-chessell
Copy link
Contributor Author

mandy-chessell commented Apr 3, 2022

Since creating the pull request I have added the following changes to the branch:

  • Consolidated the functions offered to governance action services through the context into the top-level class so that it is possible to write a governance action service that combines the function of watchdog, verification, provisioning, remediation and triage. The original specialized governance action services are still supported.
  • Updated the generic handlers so that updates to the properties that make no changes are skipped and no updates to the LatestChange classification are made. There are new log messages like this to show that an update was not needed:

[INFO] Sat Apr 02 10:40:45 BST 2022 serverinmem Information OMAG-GENERIC-HANDLERS-0010 Ignoring unnecessary update to Criticality classification attached to entity with unique identifier 7732ce9f-0f1f-4355-ae5b-784386d1da93 through method createTerm by user garygeeke
[INFO] Sat Apr 02 10:40:45 BST 2022 serverinmem Information OMAG-GENERIC-HANDLERS-0010 Ignoring unnecessary update to Confidence classification attached to entity with unique identifier 7732ce9f-0f1f-4355-ae5b-784386d1da93 through method createTerm by user garygeeke
[INFO] Sat Apr 02 10:40:45 BST 2022 serverinmem Information OMAG-GENERIC-HANDLERS-0010 Ignoring unnecessary update to Confidentiality classification attached to entity with unique identifier 7732ce9f-0f1f-4355-ae5b-784386d1da93 through method createTerm by user garygeeke
[INFO] Sat Apr 02 10:40:45 BST 2022 serverinmem Information OMAG-GENERIC-HANDLERS-0010 Ignoring unnecessary update to Retention classification attached to entity with unique identifier 7732ce9f-0f1f-4355-ae5b-784386d1da93 through method createTerm by user garygeeke
  :
[INFO] Sat Apr 02 10:40:45 BST 2022 serverinmem Information OMAG-GENERIC-HANDLERS-0010 Ignoring unnecessary update to Criticality classification attached to entity with unique identifier 7732ce9f-0f1f-4355-ae5b-784386d1da93 through method updateTerm by user garygeeke
  :
[INFO] Sat Apr 02 10:40:46 BST 2022 serverinmem Information OMAG-GENERIC-HANDLERS-0010 Ignoring unnecessary update to SpineObject classification attached to entity with unique identifier 3e24a3a1-6ac4-4e16-9ac4-6aece0d5350f through method createTerm by user garygeeke
  • There are new test cases in Data Manager FVT to test the null update.
  • New test revealed a bug in the update of schema attributes. This needed a fix to the schema attribute update functions of the generic handlers and the calls from Data Manager OMAS so that the properties stored in the embedded schema type are also updated.
  • There are new log messages for the integration daemon that shows the time taken for an integration connector to execute its refresh command.
  • There are new log messages in the GovernanceActionHandler(generic handlers) that show the state changes of a govenrance action as it runs.

Signed-off-by: Mandy Chessell <[email protected]>
@mandy-chessell
Copy link
Contributor Author

Made minor fix to iterators when max page size = 0 in shared constructor:


        if (pageSize == 0)
        {
            pageSize = MAX_PAGE_SIZE;
        }

changed to

    if (this.pageSize == 0)
    {
        this.pageSize = MAX_PAGE_SIZE;
    }

@mandy-chessell mandy-chessell merged commit ca13fa4 into odpi:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant