-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC, AL - Change effectivity dates to now #6811
Merged
alexandra-bucur
merged 9 commits into
odpi:master
from
alexandra-bucur:al-ac-effectivity-dates
Sep 26, 2022
Merged
AC, AL - Change effectivity dates to now #6811
alexandra-bucur
merged 9 commits into
odpi:master
from
alexandra-bucur:al-ac-effectivity-dates
Sep 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandra Bucur <[email protected]>
popa-raluca
approved these changes
Aug 22, 2022
bogdan-sava
requested changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LocalDateTime instead of LocalDate ?
Signed-off-by: Alexandra Bucur <[email protected]>
…c-effectivity-dates
After we discussed, we decided that what was missing was the time and I changed the ClockService to include it too. |
bogdan-sava
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexandra Bucur [email protected]
Description
Add now as date value for effective time in Asset Lineage and Asset Catalog handlers.
Testing
JUnits