-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preformance enhancement for security checking (#6697) #6886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
mandy-chessell
requested review from
planetf1,
davidradl,
popa-raluca and
lcpopa
as code owners
September 3, 2022 10:30
...src/main/java/org/odpi/openmetadata/metadatasecurity/ffdc/OpenMetadataSecurityErrorCode.java
Show resolved
Hide resolved
...tadata/accessservices/analyticsmodeling/synchronization/SoftwareServerCapabilityHandler.java
Show resolved
Hide resolved
...tadata-types/src/main/java/org/odpi/openmetadata/opentypes/OpenMetadataTypesArchive3_11.java
Show resolved
Hide resolved
...java/org/odpi/openmetadata/commonservices/generichandlers/OpenMetadataAPIGenericHandler.java
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/metadatasecurity/server/OpenMetadataServerSecurityVerifier.java
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/metadatasecurity/server/OpenMetadataServerSecurityVerifier.java
Show resolved
Hide resolved
...java/org/odpi/openmetadata/commonservices/generichandlers/OpenMetadataAPIGenericHandler.java
Show resolved
Hide resolved
open-metadata-implementation/common-services/metadata-security/metadata-security-server/pom.xml
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/metadatasecurity/server/OpenMetadataServerSecurityVerifier.java
Show resolved
Hide resolved
...src/main/java/org/odpi/openmetadata/metadatasecurity/ffdc/OpenMetadataSecurityErrorCode.java
Show resolved
Hide resolved
...tadata-types/src/main/java/org/odpi/openmetadata/opentypes/OpenMetadataTypesArchive3_11.java
Show resolved
Hide resolved
...tadata/accessservices/analyticsmodeling/synchronization/SoftwareServerCapabilityHandler.java
Show resolved
Hide resolved
...java/org/odpi/openmetadata/commonservices/generichandlers/OpenMetadataAPIGenericHandler.java
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/metadatasecurity/server/OpenMetadataServerSecurityVerifier.java
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/metadatasecurity/server/OpenMetadataServerSecurityVerifier.java
Show resolved
Hide resolved
...java/org/odpi/openmetadata/commonservices/generichandlers/OpenMetadataAPIGenericHandler.java
Show resolved
Hide resolved
open-metadata-implementation/common-services/metadata-security/metadata-security-server/pom.xml
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/metadatasecurity/server/OpenMetadataServerSecurityVerifier.java
Show resolved
Hide resolved
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Final commit adds a new type called RootSchemaType. This is inserted in the SchemaType inheritance hierarchy for the schema types that connect the schema to the asset/port etc. See models 53xx for its use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the change suggested in #6697. Essentially the formating of the asset and connection bean for calls to the security connector now occur after the metadata-security module has determined there is a security connector to call rather than on every request. It will make no difference to a server running the security connector. Those servers not running the security connector will run faster. The other benefit is that the bean formatting code has moved from the generic handler to the metadata security module which is better modularization.
During the testing I spotted that the generic handlers were checking that the qualified name is unique twice during the create call. This is an expensive check to make since it requires a query to the cohort so removing the second check will improve performance on the create.
Fixing this bug meant the parameters that pass the unique parameter on the create bean call were no longer needed and so this method no longer has these parameters and all of the callers have been updated.
Other bugs I discovered were that the ValidValuesImplementation relationship, which should be multi-link was using the uni-link creation method which means that the second mapping relationship for a code table will fail. This will impact the GHC issue odpi/egeria-samples-api#8 which will require this fix to run.
Finally I updated the type archive for release 3.12
Related Issue(s)
#6697
Testing
FVT and the open metadata labs
Release Notes & Documentation
Just internal
Additional notes