Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preformance enhancement for security checking (#6697) #6886

Merged
merged 6 commits into from
Sep 4, 2022

Conversation

mandy-chessell
Copy link
Contributor

@mandy-chessell mandy-chessell commented Sep 3, 2022

Description

This PR makes the change suggested in #6697. Essentially the formating of the asset and connection bean for calls to the security connector now occur after the metadata-security module has determined there is a security connector to call rather than on every request. It will make no difference to a server running the security connector. Those servers not running the security connector will run faster. The other benefit is that the bean formatting code has moved from the generic handler to the metadata security module which is better modularization.

During the testing I spotted that the generic handlers were checking that the qualified name is unique twice during the create call. This is an expensive check to make since it requires a query to the cohort so removing the second check will improve performance on the create.

Fixing this bug meant the parameters that pass the unique parameter on the create bean call were no longer needed and so this method no longer has these parameters and all of the callers have been updated.

Other bugs I discovered were that the ValidValuesImplementation relationship, which should be multi-link was using the uni-link creation method which means that the second mapping relationship for a code table will fail. This will impact the GHC issue odpi/egeria-samples-api#8 which will require this fix to run.

Finally I updated the type archive for release 3.12

Related Issue(s)

#6697

Testing

FVT and the open metadata labs

Release Notes & Documentation

Just internal

Additional notes

Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
@mandy-chessell
Copy link
Contributor Author

Final commit adds a new type called RootSchemaType. This is inserted in the SchemaType inheritance hierarchy for the schema types that connect the schema to the asset/port etc. See models 53xx for its use.

@mandy-chessell mandy-chessell merged commit 2286022 into odpi:master Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant