Better Javadoc and REST URL specification #6890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
mandy-chessell
requested review from
planetf1,
alexandra-bucur and
lcpopa
as code owners
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...t/src/main/java/org/odpi/openmetadata/accessservices/assetconsumer/client/AssetConsumer.java
Fixed
Show resolved
Hide resolved
...-client/src/main/java/org/odpi/openmetadata/accessservices/assetowner/client/AssetOwner.java
Fixed
Show resolved
Hide resolved
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the number of packages that are included in the javadoc. Specific the bean packages and REST beans.
It restructured the base class for ConnectedAsset to make it neater to include as a client in multiple OMASs.
It also deletes the obsolete clients from Community Profile OMAS. One of these clients was being used by the GovernanceLeadershipSample and so this needed to be recoded from the PersonalProfileManagement to the OrganizationManagement/UserIdentityManagement clients.
In rewriting the GovernanceLeadershipSample I discovered a missing method in the UserIdentityManagement client because it was not possible to set up the userIdentity entity to be anchored on the profile so there is now a new method called createUserIdentityForProfile() method.
I also noticed that there was inconsistency in how the OMASs where building there URLs in the client. This led to some URLs to miss off the serverPlatformURLRoot and others to include it twice. Therefore to reduce the randomness of these errors, the following OMASs form their URLs in a consistent way:
This is good preparation to the refactoring of many of the REST API calls to a more consistent approach that gives opportunities for common methods in the clients.
Related Issue(s)
The updates to the Topic Integrator OMIS for #6630 are included.
Testing
FVTs - the governance samples now exit with -1 if there is an unexpected condition. This causes the build to stop if any of the samples fail (before their problems were ignored).
Release Notes & Documentation
No impact
Additional notes
None