Add client for translations and valid metadata sets #6894
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public String toString() | ||
| { | ||
| return "TranslationDetailResponse{" + | ||
| "element=" + element + |
Check notice
Code scanning / CodeQL
Use of default toString()
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| * @return result of comparison | ||
| */ | ||
| @Override | ||
| public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
| public boolean equals(Object objectToCompare) | |
| if (!(objectToCompare instanceof TranslationListResponse)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| * @return result of comparison | ||
| */ | ||
| @Override | ||
| public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
| public boolean equals(Object objectToCompare) | |
| if (!(objectToCompare instanceof ValidMetadataValueListResponse)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| Objects.equals(preferredValue, that.preferredValue) && | ||
| Objects.equals(additionalProperties, that.additionalProperties) && | ||
| Objects.equals(effectiveFrom, that.effectiveFrom) && | ||
| Objects.equals(effectiveTo, that.effectiveTo); |
There was a problem hiding this comment.
UndefinedEquals: Date does not have well-defined equals behavior.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| Objects.equals(scope, that.scope) && | ||
| Objects.equals(preferredValue, that.preferredValue) && | ||
| Objects.equals(additionalProperties, that.additionalProperties) && | ||
| Objects.equals(effectiveFrom, that.effectiveFrom) && |
There was a problem hiding this comment.
UndefinedEquals: Date does not have well-defined equals behavior.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Signed-off-by: Mandy Chessell [email protected]
Description
This PR adds the client-side to the OpenMetadataClient that supports translations of open metadata entities and valid metadata sets.
Testing
No testing since this is client-side only to get feedback on the methods.
Release Notes & Documentation
Not yet
Additional notes