-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Data Manager OMAS REST API; Begin Digital Service OMAS API #6908
Conversation
Signed-off-by: Mandy Chessell <[email protected]>
return false; | ||
} | ||
DigitalSubscriptionProperties that = (DigitalSubscriptionProperties) objectToCompare; | ||
return getSupportLevel() == that.getSupportLevel() && |
Check warning
Code scanning / CodeQL
Reference equality test on strings
* | ||
* @param qualifiedName String name | ||
*/ | ||
public void setQualifiedName(String qualifiedName) |
Check notice
Code scanning / CodeQL
Missing Override annotation
* | ||
* @return String name | ||
*/ | ||
public String getQualifiedName() |
Check notice
Code scanning / CodeQL
Missing Override annotation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an error - should not be overriding - removed code in next PR
...g/odpi/openmetadata/accessservices/digitalservice/metadataelements/ContactMethodElement.java
Show resolved
Hide resolved
* @return boolean result of comparison | ||
*/ | ||
@Override | ||
public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
public boolean equals(Object objectToCompare) | |
if (!(objectToCompare instanceof TemplateProperties)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
.../org/odpi/openmetadata/accessservices/digitalservice/properties/ReferenceableProperties.java
Show resolved
Hide resolved
* @return result of comparison | ||
*/ | ||
@Override | ||
public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
public boolean equals(Object objectToCompare) | |
if (!(objectToCompare instanceof ClassificationRequestBody)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code generated by IntelliJ
...org/odpi/openmetadata/accessservices/digitalservice/properties/ClassificationProperties.java
Show resolved
Hide resolved
...java/org/odpi/openmetadata/accessservices/digitalservice/rest/ExternalSourceRequestBody.java
Show resolved
Hide resolved
* @return result of comparison | ||
*/ | ||
@Override | ||
public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
public boolean equals(Object objectToCompare) | |
if (!(objectToCompare instanceof DigitalServiceOutboundEvent)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
...ava/org/odpi/openmetadata/accessservices/digitalservice/metadataelements/RelatedElement.java
Show resolved
Hide resolved
* @return boolean result of comparison | ||
*/ | ||
@Override | ||
public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
public boolean equals(Object objectToCompare) | |
if (!(objectToCompare instanceof LicenseTypeProperties)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
...a/org/odpi/openmetadata/accessservices/digitalservice/properties/UserIdentityProperties.java
Show resolved
Hide resolved
* @return result of comparison | ||
*/ | ||
@Override | ||
public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
public boolean equals(Object objectToCompare) | |
if (!(objectToCompare instanceof DigitalSubscriptionProperties)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
...ava/org/odpi/openmetadata/accessservices/digitalservice/metadataelements/ProfileElement.java
Show resolved
Hide resolved
* @return result of comparison | ||
*/ | ||
@Override | ||
public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
public boolean equals(Object objectToCompare) | |
if (!(objectToCompare instanceof PersonRoleHistory)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
.../org/odpi/openmetadata/accessservices/digitalservice/properties/ContactMethodProperties.java
Show resolved
Hide resolved
* @return boolean result of comparison | ||
*/ | ||
@Override | ||
public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
public boolean equals(Object objectToCompare) | |
if (!(objectToCompare instanceof Appointee)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
.../org/odpi/openmetadata/accessservices/digitalservice/metadataelements/PersonRoleElement.java
Show resolved
Hide resolved
* @return boolean result of comparison | ||
*/ | ||
@Override | ||
public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
public boolean equals(Object objectToCompare) | |
if (!(objectToCompare instanceof RelationshipProperties)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
* @return boolean result of comparison | ||
*/ | ||
@Override | ||
public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
public boolean equals(Object objectToCompare) | |
if (!(objectToCompare instanceof ActorProfileProperties)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code generated by IntelliJ
...ava/org/odpi/openmetadata/accessservices/digitalservice/properties/PersonRoleProperties.java
Show resolved
Hide resolved
* @return result of comparison | ||
*/ | ||
@Override | ||
public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
public boolean equals(Object objectToCompare) | |
if (!(objectToCompare instanceof UserIdentityElement)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
.../odpi/openmetadata/accessservices/digitalservice/properties/CertificationTypeProperties.java
Show resolved
Hide resolved
* @return result of comparison | ||
*/ | ||
@Override | ||
public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
public boolean equals(Object objectToCompare) | |
if (!(objectToCompare instanceof TeamProfileElement)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
* @return boolean result of comparison | ||
*/ | ||
@Override | ||
public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
public boolean equals(Object objectToCompare) | |
if (!(objectToCompare instanceof TeamProfileProperties)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
* @return result of comparison | ||
*/ | ||
@Override | ||
public boolean equals(Object objectToCompare) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
public boolean equals(Object objectToCompare) | |
if (!(objectToCompare instanceof PersonRoleAppointee)) |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
||
/** | ||
* | ||
* @param userId calling user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MissingSummary: A summary line is required on public/protected Javadocs.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
return false; | ||
} | ||
DigitalSubscriptionProperties that = (DigitalSubscriptionProperties) objectToCompare; | ||
return getSupportLevel() == that.getSupportLevel() && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReferenceEquality: Comparison using reference equality instead of value equality
return getSupportLevel() == that.getSupportLevel() && | |
return getSupportLevel().equals(that.getSupportLevel()) && |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
return Objects.equals(getElementHeader(), that.getElementHeader()) && | ||
Objects.equals(getProfile(), that.getProfile()) && | ||
Objects.equals(getStartDate(), that.getStartDate()) && | ||
Objects.equals(getEndDate(), that.getEndDate()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 16 similar findings have been found in this PR
UndefinedEquals: Date does not have well-defined equals behavior.
🔎 Expand here to view all instances of this finding
File Path | Line Number |
---|---|
open-metadata-implementation/access-services/digital-service/digital-service-api/src/main/java/org/odpi/openmetadata/accessservices/digitalservice/properties/DigitalProductProperties.java | 344 |
open-metadata-implementation/access-services/digital-service/digital-service-api/src/main/java/org/odpi/openmetadata/accessservices/digitalservice/metadataelements/Appointee.java | 197 |
open-metadata-implementation/access-services/governance-program/governance-program-api/src/main/java/org/odpi/openmetadata/accessservices/governanceprogram/properties/LicenseProperties.java | 517 |
open-metadata-implementation/access-services/digital-service/digital-service-api/src/main/java/org/odpi/openmetadata/accessservices/digitalservice/properties/ContactMethodProperties.java | 324 |
open-metadata-implementation/access-services/digital-service/digital-service-api/src/main/java/org/odpi/openmetadata/accessservices/digitalservice/properties/RelationshipProperties.java | 185 |
open-metadata-implementation/access-services/governance-program/governance-program-api/src/main/java/org/odpi/openmetadata/accessservices/governanceprogram/properties/LicenseProperties.java | 516 |
open-metadata-implementation/access-services/digital-service/digital-service-api/src/main/java/org/odpi/openmetadata/accessservices/digitalservice/properties/ContactMethodProperties.java | 325 |
open-metadata-implementation/access-services/digital-service/digital-service-api/src/main/java/org/odpi/openmetadata/accessservices/digitalservice/properties/LicenseProperties.java | 517 |
open-metadata-implementation/access-services/digital-service/digital-service-api/src/main/java/org/odpi/openmetadata/accessservices/digitalservice/properties/ClassificationProperties.java | 183 |
open-metadata-implementation/access-services/digital-service/digital-service-api/src/main/java/org/odpi/openmetadata/accessservices/digitalservice/properties/DigitalProductProperties.java | 346 |
Showing 10 of 16 findings. Visit the Lift Web Console to see all.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
Signed-off-by: Mandy Chessell [email protected]
Description
The Data Manager OMAS has been developed over a number of years. Each extension added explicit support for a particular type of technology. The first API was support for databases. Experience has taught us that passing names, search parameters etc on the URL can cause errors and they are better in the request body. The database API also forced all database elements to have "ExternalSource" provenance.
This PR primarily provides the refactoring of the Data Manager OMAS REST API. There are minor enhancements to the Java API:
In addition, this PR includes definitions for part of the Java API for the Digital Service OMAS that includes:
This OMAS will eventually include the ability to set up and appoint digital service managers, create and maintain information about digital products, their specification and licenses. It will be possible to view the subscriptions and use of the products.
Testing
Data Manager OMAS - Regression testing with the FVTs
Digital Service OMAS - Nothing runs yet - just Java interfaces at this point.
Release Notes & Documentation
Need to document that the REST API has changed - however, this is not a supported API so not breaking backward compatibility. Postman collections, for example, need updating.